Re: [PATCH] ReplicatedPG: For async-read, set the real result after completing read.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks about right, file a pull request?
-Sam

On Thu, Jul 10, 2014 at 2:23 AM, Ma, Jianpeng <jianpeng.ma@xxxxxxxxx> wrote:
> When reading an object from replicated pool, ceph uses sync mode, so it can set the results in execute_ctx correctly.
> However, For the async-read in EC Pool, current code didn't set the real results after read in complete_read_ctx.
>
> Signed-off-by: Ma Jianpeng <jianpeng.ma@xxxxxxxxx>
> ---
>  src/osd/ReplicatedPG.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc
> index cab3fde..ac0e8ad 100644
> --- a/src/osd/ReplicatedPG.cc
> +++ b/src/osd/ReplicatedPG.cc
> @@ -5318,7 +5318,7 @@ void ReplicatedPG::complete_read_ctx(int result, OpContext *ctx)
>      // on ENOENT, set a floor for what the next user version will be.
>      reply->set_enoent_reply_versions(info.last_update, info.last_user_version);
>    }
> -
> +  reply->set_result(result);
>    reply->add_flags(CEPH_OSD_FLAG_ACK | CEPH_OSD_FLAG_ONDISK);
>    osd->send_message_osd_client(reply, m->get_connection());
>    close_op_ctx(ctx, 0);
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux