On Tue, Jul 8, 2014 at 2:36 AM, Alex Elder <elder@xxxxxxxx> wrote: > On 06/25/2014 12:16 PM, Ilya Dryomov wrote: >> In the past, rbd_dev_header_watch_sync() used to handle both watch and >> unwatch requests and was entangled and leaky. Commit b30a01f2a307 >> ("rbd: fix osd_request memory leak in __rbd_dev_header_watch_sync()") >> split it into two separate functions. This commit cleanly abstracts >> the common bits, relying on the fixed rbd_obj_request_wait(). > > Adding this without calling it leads to an unused function > warning in the build, I'm sure. > > You could probably squash this into the next patch. It used to be a single patch in the previous version of this series, but it was too hard to review even for myself, so I had to split it. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html