Re: [PATCH] rbd: fix ida/idr memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/04/2014 11:38 AM, Ilya Dryomov wrote:
> ida_destroy() needs to be called on module exit to release ida caches.

Looks good to me.

Reviewed-by: Alex Elder <elder@xxxxxxxxxx>

> Signed-off-by: Ilya Dryomov <ilya.dryomov@xxxxxxxxxxx>
> ---
>  drivers/block/rbd.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 94747afc2e78..ecdd4aee173c 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5464,6 +5464,7 @@ err_out_slab:
>  
>  static void __exit rbd_exit(void)
>  {
> +	ida_destroy(&rbd_dev_id_ida);
>  	rbd_sysfs_cleanup();
>  	if (single_major)
>  		unregister_blkdev(rbd_major, RBD_DRV_NAME);
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux