New Defects reported by Coverity Scan for ceph (fwd)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



--- Begin Message ---

Hi,


Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1204293:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
/mds/MDS.cc: 1714 in MDS::respawn()()

** CID 1204294:  Resource leak  (RESOURCE_LEAK)
/osd/ReplicatedPG.cc: 980 in ReplicatedPG::do_pg_op(std::tr1::shared_ptr<OpRequest>)()

** CID 1204295:  Uninitialized scalar field  (UNINIT_CTOR)
/osd/osd_types.h: 2716 in ObjectContext::RWState::RWState()()

** CID 1204296:  Uninitialized scalar field  (UNINIT_CTOR)
/osdc/Objecter.h: 1165 in Objecter::Op::Op(const object_t &, const object_locator_t &, std::vector<OSDOp, std::allocator<OSDOp>> &, int, Context *, Context *, unsigned long *)()
/osdc/Objecter.h: 1165 in Objecter::Op::Op(const object_t &, const object_locator_t &, std::vector<OSDOp, std::allocator<OSDOp>> &, int, Context *, Context *, unsigned long *)()


________________________________________________________________________________________________________
*** CID 1204293:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
/mds/MDS.cc: 1714 in MDS::respawn()()
1708         char buf[PATH_MAX];
1709         char *cwd = getcwd(buf, sizeof(buf));
1710         assert(cwd);
1711         dout(1) << " cwd " << cwd << dendl;
1712     
1713         /* Fall back to a best-effort: just running in our CWD */
>>>     CID 1204293:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
>>>     Calling strncpy with a maximum size argument of 4096 bytes on destination array "exe_path" of size 4096 bytes might leave the destination string unterminated.
1714         strncpy(exe_path, orig_argv[0], sizeof(exe_path));
1715       }
1716     
1717       dout(1) << " exe_path " << exe_path << dendl;
1718     
1719       unblock_all_signals(NULL);

________________________________________________________________________________________________________
*** CID 1204294:  Resource leak  (RESOURCE_LEAK)
/osd/ReplicatedPG.cc: 980 in ReplicatedPG::do_pg_op(std::tr1::shared_ptr<OpRequest>)()
974     	    // FIXME: EC not supported yet
975     	    result = -EOPNOTSUPP;
976     	    break;
977     	  }
978     	  if (is_unreadable_object(oid)) {
979     	    wait_for_unreadable_object(oid, op);
>>>     CID 1204294:  Resource leak  (RESOURCE_LEAK)
>>>     Variable "filter" going out of scope leaks the storage it points to.
980     	    return;
981     	  }
982     	  result = osd->store->read(coll, oid, 0, 0, osd_op.outdata);
983     	}
984           }
985           break;

________________________________________________________________________________________________________
*** CID 1204295:  Uninitialized scalar field  (UNINIT_CTOR)
/osd/osd_types.h: 2716 in ObjectContext::RWState::RWState()()
2710         /// if set, restart backfill when we can get a read lock
2711         bool backfill_read_marker;
2712     
2713         /// if set, requeue snaptrim on lock release
2714         bool snaptrimmer_write_marker;
2715     
>>>     CID 1204295:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member "snaptrimmer_write_marker" is not initialized in this constructor nor in any functions that it calls.
2716         RWState() : state(RWNONE), count(0), backfill_read_marker(false) {}
2717         bool get_read(OpRequestRef op) {
2718           if (get_read_lock()) {
2719     	return true;
2720           } // else
2721           waiters.push_back(op);

________________________________________________________________________________________________________
*** CID 1204296:  Uninitialized scalar field  (UNINIT_CTOR)
/osdc/Objecter.h: 1165 in Objecter::Op::Op(const object_t &, const object_locator_t &, std::vector<OSDOp, std::allocator<OSDOp>> &, int, Context *, Context *, unsigned long *)()
1159     	out_handler[i] = NULL;
1160     	out_rval[i] = NULL;
1161           }
1162     
1163           if (target.base_oloc.key == o)
1164     	target.base_oloc.key.clear();
>>>     CID 1204296:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member "used_replica" is not initialized in this constructor nor in any functions that it calls.
1165         }
1166         ~Op() {
1167           while (!out_handler.empty()) {
1168     	delete out_handler.back();
1169     	out_handler.pop_back();
1170           }
/osdc/Objecter.h: 1165 in Objecter::Op::Op(const object_t &, const object_locator_t &, std::vector<OSDOp, std::allocator<OSDOp>> &, int, Context *, Context *, unsigned long *)()
1159     	out_handler[i] = NULL;
1160     	out_rval[i] = NULL;
1161           }
1162     
1163           if (target.base_oloc.key == o)
1164     	target.base_oloc.key.clear();
>>>     CID 1204296:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member "used_replica" is not initialized in this constructor nor in any functions that it calls.
1165         }
1166         ~Op() {
1167           while (!out_handler.empty()) {
1168     	delete out_handler.back();
1169     	out_handler.pop_back();
1170           }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/25?tab=Overview

To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py




--- End Message ---

[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux