On Thu, Apr 10, 2014 at 1:29 PM, Zhang Zhen <zhenzhang.zhang@xxxxxxxxxx> wrote:
> posix_acl_xattr_set() already does the check, and it's the only
> way to feed in an ACL from userspace.
> So the check here is useless, remove it.
>
> Signed-off-by: zhang zhen <zhenzhang.zhang@xxxxxxxxxx>
> ---
> fs/ceph/acl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c
> index 21887d6..469f2e8 100644
> --- a/fs/ceph/acl.c
> +++ b/fs/ceph/acl.c
> @@ -104,12 +104,6 @@ int ceph_set_acl(struct inode *inode, struct posix_acl *acl, int type)
> umode_t new_mode = inode->i_mode, old_mode = inode->i_mode;
> struct dentry *dentry;
>
> - if (acl) {
> - ret = posix_acl_valid(acl);
> - if (ret < 0)
> - goto out;
> - }
> -
> switch (type) {
> case ACL_TYPE_ACCESS:
> name = POSIX_ACL_XATTR_ACCESS;
> --
> 1.8.5.5
>
aded to our testing branch. Thanks.
Yan, Zheng
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
