On 03/26/2014 06:43 AM, Ilya Dryomov wrote: > It looks like img_request kref currenlty exists for posterity only. > Unless I'm missing something, its counter is set to 1 in > rbd_img_request_create() and is not incremented anywhere else, which > means that the instant rbd_img_request_put() is called, img_request is > freed. I naively assumed it was incremented and decremented in > rbd_img_obj_request_add() and rbd_img_obj_request_del() respectively.. > Maybe that's something we should look at first? I believe it was something that I never finished implementing. So yes, the kref is there to be used, it just isn't, really. If you want to give it a try, be my guest. I'll review it carefully. (I can't really test my changes very well anyway.) If you want me to do it, let me know. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html