On Wed, Mar 12, 2014 at 12:28:16AM -0500, Alex Elder wrote: > On 03/11/2014 11:24 PM, Guangliang Zhao wrote: Hi Alex, Thanks very much for the reviews, version 2 would coming soon. > > Hi, > > > > I am sorry that didn't notice Jean-Tiare's mail at all, just sage's > > reminds me. > > > > There are 3 patches, the first is optimization for rbd writing, the > > remaining two are support for rbd discard. If you have completed the > > discard things, just ignore them. > > > > Guangliang Zhao (3): > > rbd: skip the copyup when an entire object writing > > rbd: extend the operation type > > rbd: add discard support for rbd > > > > drivers/block/rbd.c | 190 +++++++++++++++++++++++++++++++++++++++++---------- > > 1 file changed, 154 insertions(+), 36 deletions(-) > > > > Oh, one more thing. I reviewed only the code changes presented > here. I did not go back to walk through the discard call chains > to make sure you're doing things correctly. I'm just assuming > that, and based on that, I think your changes look overall correct > to me. > > -Alex -- Best regards, Guangliang -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
