On 02/28/2014 06:14 PM, Yan, Zheng wrote:
>>@@ -474,7 +474,7 @@ static loff_t ceph_dir_llseek(struct file *file, loff_t offset, int whence)
>> {
>> struct ceph_file_info *fi = file->private_data;
>> struct inode *inode = file->f_mapping->host;
>>- loff_t old_offset = offset;
>>+ loff_t old_offset = ceph_make_fpos(fi->frag, fi->next_offset);
>
>Should this be named "next_offset" (or maybe "current_offset")?
>It doesn't seem "old" to me, though I do realize it doesn't
>necessarily represent where the "next" file position will be.
>
No. next_offset is the position where next readdir request will be.
I guess "old_next_offset" is what it is but in any case looking
again I see what you mean now. Thanks.
-Alex
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html