On Mon, Feb 24, 2014 at 4:58 PM, Alex Elder <elder@xxxxxxxx> wrote:
> On 02/21/2014 12:55 PM, Ilya Dryomov wrote:
>> Hello,
>>
>> This series adds support for CEPH_OSD_OP_SETALLOCHINT osd op to libceph
>> along with adjusting rbd to make use of it. The rationale and the
>> basic desing was outlined in the "rados io hints" thread on ceph-devel
>> about a month ago.
>
> It looks like some of this discussion is still active, so it
> might be a little premature to implement this. That being said,
> I reviewed what you have. Overall it looks good to me. I have
> some small suggestions for you to consider. I also think that
> in this case just extending the definition of a write request
> is preferable to encoding this stuff in a distinct new op, but
> I may be missing some information.
Hi Alex,
Thanks for the review! I've incorporated most of your suggestions, see
my replies for details. I'll post v2 series shortly, feel free to send
your Reviewed-by for 6/6 any time ;)
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
