Re: [PATCH] mds: handle setxattr ceph.parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 18, 2013 at 9:09 AM, Sage Weil <sage@xxxxxxxxxxx> wrote:
> On Wed, 18 Dec 2013, Alexandre Oliva wrote:
>> On Dec 18, 2013, "Yan, Zheng" <ukernel@xxxxxxxxx> wrote:
>>
>> > On Tue, Dec 17, 2013 at 7:25 PM, Alexandre Oliva <oliva@xxxxxxx> wrote:
>> >> # setfattr -n ceph.parent /cephfs/mount/path/name
>
> Can we add an additional prefix indicating that this is a debug/developer
> kludge that is not intended to be supported in the long-term?
> ceph.dev.force_rewrite_backtrace or something?

While the "ceph.dev" namespace might be a good idea for other things,
I'm not sure we should merge anything that we can't support long-term.
This probably wouldn't be too hard to get working properly, but if
it's only going to impact people who have been using CephFS for so
long they can build their own clusters I'm not sure it's worth the
effort?
In particular, I don't think this interacts properly with projection,
so we can't make any guarantees that it's actually done what the user
wants if there are ongoing changes, and it's sort of weird to not pay
attention to if the update actually succeeds...
-Greg
Software Engineer #42 @ http://inktank.com | http://ceph.com

>
> sage
>
>>
>> > This seems like a good solution for fixing cephfs that was created
>> > before dumpling.
>>
>> There's more to it than just that, actually.  Renaming an entire subtree
>> won't update the parent attribute of files in there, so they will appear
>> to be incorrect (*).  This patch introduces a mechanism that could be
>> used to force them to be updated.
>>
>> (*) I'm well aware that they contain enough information to find the
>> updated information, so the redundant info in this attribute can be
>> harmlessly out-of-date, but if someone plans to use the data for other
>> purposes (like I sometimes do), it's useful to have them fully up to
>> date.  I also move large trees around, which makes this issue visible.
>>
>> --
>> Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
>> You must be the change you wish to see in the world. -- Gandhi
>> Be Free! -- http://FSFLA.org/   FSF Latin America board member
>> Free Software Evangelist      Red Hat Brazil Compiler Engineer
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux