This does seem to fix the issue. Thanks! On Mon, Nov 25, 2013 at 3:02 PM, Josh Durgin <josh.durgin@xxxxxxxxxxx> wrote: > On 11/25/2013 11:01 AM, Tim Spriggs wrote: >> >> ... ping >> >> On Thu, Nov 7, 2013 at 3:31 PM, Tim Spriggs <tims@xxxxxxxxxxxx> wrote: >>> >>> Oops, I just realized I did the patch in the wrong direction :) >>> >>> On Thu, Nov 7, 2013 at 3:06 PM, Tim Spriggs <tims@xxxxxxxxxxxx> wrote: >>>> >>>> Hi All, >>>> >>>> I am battling extraneous error messages from two sources: >>>> >>>> logrotate which is run in cron.daily and has a definition from the >>>> ceph package in /etc/logrotate.d. The message I get in an email from >>>> every node once a day is: >>>> >>>> cat: /var/run/ceph/osd.3.pid: No such file or directory >>>> >>>> This comes up because upstart is actually running ceph-osd while the >>>> init.d script expects a pidfile. >>>> >>>> >>>> /var/log/ceph/ceph-osd.$id.log which complains: >>>> >>>> ERROR: error converting store /var/lib/ceph/osd/ceph-3: (16) Device or >>>> resource busy >>>> >>>> This happens on boot as well as on log rotation. >>>> >>>> >>>> After talking with dmick on irc.oftc.net#ceph, I was alerted to the >>>> fact that there are bits in upstart as well as the sysvinit style >>>> script that attempt to only use one scheme or the other. However, the >>>> logic seems wrong. Inside of ceph_common.sh, there is a function named >>>> check_host which looks for /var/lib/ceph/$type/ceph-$id/sysvinit and >>>> if it exists, it returns. If it doesn't exist, it just goes on to the >>>> next check (which passes in my environment.) Instead, it should return >>>> a non-0 value. Attached is an example patch. > > > I think continuing if the host matches is intentional, so the init > script continues working for daemons deployed before > /var/lib/ceph/$type/ceph-$id/sysvinit or > /var/lib/ceph/$type/ceph-$id/upstart were used. > > To maintain backwards compatibility, and prevent both upstart and sysvinit > from trying to manage the same daemons, I think we can exit > if the file for the other init system is present, like this patch: > > https://github.com/ceph/ceph/commit/b1d260cabb90bb9155f18c8e38a1dca102e6466c > > Does this work for you? > > Josh -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
