Can we take that diff you provided as coming with a signed-off-by, as in the pull request Loic generated? :) -Greg Software Engineer #42 @ http://inktank.com | http://ceph.com On Thu, Nov 21, 2013 at 9:57 AM, Loic Dachary <loic@xxxxxxxxxxx> wrote: > Hi, > > It turns out there was no pull request or bug report, sorry about that. Here is the pull request with your patch included: > > https://github.com/ceph/ceph/pull/861 > > Cheers > > On 21/11/2013 18:18, Loic Dachary wrote: >> Hi, >> >> I believe there is either a pull request or a ticket with this fix. Definitely a typo ;-) >> >> Cheers >> >> On 21/11/2013 08:23, Dietmar Maurer wrote: >>> http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD >>> >>> line 320: >>> >>> if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then >>> >>> looks strange to me. Maybe that should be: >>> >>> - if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then >>> + if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then >>> >>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> > > -- > Loïc Dachary, Artisan Logiciel Libre > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
