This approach is basically what Kyua did for libc++ compatibility. It
looks good. The only things I don't like are the
CEPH_HASH_NAMESPACE_{START,END} macros. I'm personally not a fan of
macros that change language syntax. However, I can't come up with an
alternative that doesn't involve either more C++11 features or more
#ifdefs.
-Alan
On Tue, Oct 29, 2013 at 4:51 PM, Noah Watkins <noah.watkins@xxxxxxxxxxx> wrote:
> Out of the box on OSX Mavericks libc++ [1] is being used as opposed to
> libstdc++. One of the issues is that stuff from tr1 isn't available
> (e.g. std::tr1::shared_ptr), as they have moved to std in c++11.
>
> I'm looking for any feedback on this patch set, or if there is a
> better way forward.
>
> A set of patches on ceph.git:wip-libc++ [2] adds initial support (with
> a couple temporary hacks). These patches are very similar to the
> method used to support libc++ in mongodb.
>
> Summary of changes:
>
> std::tr1::shared/weak_ptr maps to ceph::shared/weak_ptr
>
> hash_map/set maps to ceph::unordered_map/set
>
> which will choose tr1::unordered_map/set over ext/hash_map/set.
>
> [1] http://libcxx.llvm.org/
> [2] https://github.com/ceph/ceph/compare/wip-libc%2B%2B
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
