That sounds better to me, since the generation stuff triggers the same
format switch.
-Sam
On Fri, Sep 27, 2013 at 7:12 AM, Loic Dachary <loic@xxxxxxxxxxx> wrote:
> Hi David,
>
> In
>
> int FileStore::lfn_open(coll_t cid,
> const ghobject_t& oid,
> bool create,
> FDRef *outfd,
> IndexedPath *path,
> Index *index)
> {
> assert(get_allow_sharded_objects() || oid.shard_id == ghobject_t::NO_SHARD);
> assert(outfd);
>
> would it make sense to
>
> assert(get_allow_sharded_objects() || ( oid.shard_id == ghobject_t::NO_SHARD) && oid.generation == ghobject_t::NO_GEN) )
>
> instead ?
>
> Cheers
>
> --
> Loïc Dachary, Artisan Logiciel Libre
> All that is necessary for the triumph of evil is that good people do nothing.
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
