Hi Loic, I suggest still one tiny change, since if in.length does not need alignment, you still increase the in-length by the value of alignment: unsigned alignment = get_alignment(); - unsigned in_length = in.length() + alignment - ( in.length() % alignment ); + unsigned tail = in.length()%alignment; + unsigned in_length = in.length() + tail?(alignment - tail):0; Cheers Andreas. ______________________________________ From: Loic Dachary [loic@xxxxxxxxxxx] Sent: 23 September 2013 09:27 To: Andreas Joachim Peters Cc: ceph-devel@xxxxxxxxxxxxxxx Subject: Re: CEPH Erasure Encoding + OSD Scalability Hi Andreas, Very inefficient implementation indeed :-) I've integrated your change in https://github.com/ceph/ceph/pull/619 Cheers On 23/09/2013 01:00, Andreas Joachim Peters wrote: > alignment = k*w*packetsize*sizeof(int); > in_length += (alignment - (in_length%alignment); -- Loïc Dachary, Artisan Logiciel Libre All that is necessary for the triumph of evil is that good people do nothing. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
