On 09/17/2013 09:11 AM, Alex Elder wrote:
On 09/17/2013 10:24 AM, Josh Durgin wrote:
block/ioctl.c will already call set_device_ro() for us after this
driver-specific handling completes successfully, so we don't need to
call it here. Also, it appears the block layer has a bug in that
it does the check for CAP_SYS_ADMIN *after* calling the driver-specific
code for BLKROSET. So the driver-specific part could succeed, but the
generic code could fail due to this later check without the driver
knowing, possibly leaving the driver inconsistent with the block layer.
I wonder if that's intentional, but I doubt it. It predates
the original Linux-2.6.12-rc2 git commit.
But I agree with you, I think it's a bug. Do you plan to submit
a patch upstream to propose a fix?
Sure, I'll submit a patch for it.
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
