Sage, These are the changes you requested. I eliminated the use of ifdefs in the C code. It's all self contained in cache.[ch] and in the case of it being disabled becomes a nop. Also, I found a small bug where we would not free the invalidate queue on unmount. It's split into it's own commit. Finally, I saw that you had a hard time building it without the kernel flag enabled. So I made sure to test a config with fscache for Ceph disabled right before sping things. The commits are from my branch (which is based on top of the main testing branch) from my repo: https://adfin@xxxxxxxxxxxxx/adfin/linux-fs.git branch: wip-ceph-fscache Best, - Milosz Milosz Tanski (2): ceph: Do not leak fscache workqueue ceph: fscache cleanup fs/ceph/cache.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++------- fs/ceph/cache.h | 68 +++++++++++++++++++------------------------ fs/ceph/inode.c | 61 +------------------------------------- fs/ceph/super.c | 22 ++++---------- fs/ceph/super.h | 1 - 5 files changed, 115 insertions(+), 127 deletions(-) -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html