On 08/15/2013 11:45 PM, Loic Dachary wrote:
Hi Josh, From https://github.com/ceph/ceph/pull/504 I see that your comments persisted despite a rebase and show as jdurgin discussed an outdated diff 8 hours ago I would like to do the same but when I comment inline, it shows differently and gets trashed by a rebase. I'm curious to learn how you do it :-)
The interface isn't ideal - if you comment on the pull request diff (i.e. https://github.com/ceph/ceph/pull/504/files) instead of the individual commits, then your comments will stay associated with the pull request (and still appear on new versions of the branch if the line they're on didn't change). Josh -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
