On Wed, 3 Jul 2013, Sage Weil wrote: > On Thu, 4 Jul 2013, Yan, Zheng wrote: > > On Thu, Jul 4, 2013 at 5:57 AM, Sage Weil <sage@xxxxxxxxxxx> wrote: > > > Hi Yan- > > > > > > On Mon, 1 Jul 2013, Sage Weil wrote: > > >> On Mon, 1 Jul 2013, Yan, Zheng wrote: > > >> > ping > > >> > > > >> > I think this patch should goes into 3.11 or fix the issue by other means > > >> > > >> Applied this to the testing branch, thanks. Let me know if there are any > > >> others I missed! > > > > > > This broke rbd, which was using the unsafe callback. I pushed a patch to > > > simplify that (testing-next^); care to take a look? > > > > > > > the patch looks good. looks like issue #5146 actually does not exist. > > Alex, could you take a look. > > Yeah, i'll close. Ok, I just realized that my patch is essentially reverting 12166906, which AFAICS was based on the assumption that ONDISK would get an ACK but not ONDISK reply from the OSD, but in reality we get only the ONDISK. We should just drop them both... sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html