Hi, The ceph summit was a great source of inspiration and feedback :-) I tried to take into account Sam's suggestion to not define a base class but to extract components that could be re-used for the implementation of the ErasureEncodedPG. To get there as smoothly as possible, I propose to reverse engineer the API and write tests for it ( my attempts are inconclusive but I'm hopefull https://github.com/dachary/ceph/commit/3ea566e5918dd099de17bc2febadc9c49f782f0e ). The tests can then be used when extracting a common component to help make sure there is no regression or other unintented side effects. I created a task for it ( http://tracker.ceph.com/issues/4928 ) and made it a child of an enclosing task for the implementation of erasure encoding ( http://tracker.ceph.com/issues/4929 ) to track down the related tickets. Cheers -- Loïc Dachary, Artisan Logiciel Libre All that is necessary for the triumph of evil is that good people do nothing.
Attachment:
signature.asc
Description: OpenPGP digital signature
