On Tue, Apr 30, 2013 at 06:57:14AM -0500, Alex Elder wrote: > On 04/30/2013 02:24 AM, Dan Carpenter wrote: > > Hello Alex Elder, > > > > This is a semi-automatic email about new static checker warnings. > > Cool, I've never used smatch before. Great to get these > automated warnings. > > I looked at this, and this is not a problem. An earlier > commit, about 10 before that one: > rbd: always check IMG_DATA flag > implements a comparable check. Any rbd object request > with the IMG_DATA flag set (obj_request_img_data_test() > returns true) will have a non-null image_request pointer. > > I suppose I should have asserted it was non-null, I do > that all over the place... If Smatch knows a variable is never NULL then it ignores inconsistent NULL checking but it would be better to just remove the unneeded check. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
