Currently, a watch on an rbd device header object gets torn down
when its final Linux device reference gets dropped. Instead, tear
it down when removing the device. If an error occurs cleaning up
the watch event, abort the unmap request.
All images (including parents) still get watch requests set up, so
tear these down also, in rbd_dev_remove_parent(). For now, ignore
any errors that occur in this case.
Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
---
drivers/block/rbd.c | 32 ++++++++++++++++++++------------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index c72dcdf..d7a36d1 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4713,6 +4713,10 @@ static int rbd_dev_probe_finish(struct rbd_device
*rbd_dev)
{
int ret;
+ ret = rbd_dev_header_watch_sync(rbd_dev, 1);
+ if (ret)
+ return ret;
+
/* generate unique id: find highest unique id, add one */
rbd_dev_id_get(rbd_dev);
@@ -4743,10 +4747,6 @@ static int rbd_dev_probe_finish(struct rbd_device
*rbd_dev)
* of the sysfs code (initiated by rbd_bus_del_dev()).
*/
- ret = rbd_dev_header_watch_sync(rbd_dev, 1);
- if (ret)
- goto err_out_bus;
-
ret = rbd_dev_set_mapping(rbd_dev);
if (ret)
goto err_out_bus;
@@ -4775,6 +4775,7 @@ err_out_id:
rbd_dev_id_put(rbd_dev);
if (rbd_dev->parent);
rbd_dev_remove_parent(rbd_dev);
+ (void)rbd_dev_header_watch_sync(rbd_dev, 0);
return ret;
}
@@ -4970,9 +4971,6 @@ static void rbd_dev_release(struct device *dev)
{
struct rbd_device *rbd_dev = dev_to_rbd_dev(dev);
- if (rbd_dev->watch_event)
- rbd_dev_header_watch_sync(rbd_dev, 0);
-
/* clean up and free blkdev */
rbd_free_disk(rbd_dev);
unregister_blkdev(rbd_dev->major, rbd_dev->name);
@@ -5007,6 +5005,7 @@ static void rbd_dev_remove_parent(struct
rbd_device *rbd_dev)
second = third;
}
rbd_assert(second);
+ (void)rbd_dev_header_watch_sync(second, 0);
rbd_remove_all_snaps(second);
rbd_bus_del_dev(second);
first->parent = NULL;
@@ -5023,13 +5022,13 @@ static ssize_t rbd_remove(struct bus_type *bus,
size_t count)
{
struct rbd_device *rbd_dev = NULL;
- int target_id, rc;
+ int target_id;
unsigned long ul;
- int ret = count;
+ int ret;
- rc = strict_strtoul(buf, 10, &ul);
- if (rc)
- return rc;
+ ret = strict_strtoul(buf, 10, &ul);
+ if (ret)
+ return ret;
/* convert to int; abort if we lost anything in the conversion */
target_id = (int) ul;
@@ -5053,6 +5052,15 @@ static ssize_t rbd_remove(struct bus_type *bus,
if (ret < 0)
goto done;
+ ret = rbd_dev_header_watch_sync(rbd_dev, 0);
+ if (ret) {
+ rbd_warn(rbd_dev, "error dropping header watch (%d)\n", ret);
+ clear_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags);
+ smp_mb();
+ return ret;
+ }
+ ret = count;
+
if (rbd_dev->parent)
rbd_dev_remove_parent(rbd_dev);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
