(This series, and the patch I just posted, are available in the "review/wip-rbd-cleanup" branch of the ceph-client git repository.) This series is one of several I expect to be posting that are mostly small tweaks and polish to the rbd code. I'm doing a review of the whole thing with an eye toward verifying error paths and finding memory leaks. Along the way I'm making small changes to improve overall consistency and perhaps shore up some coding style issues. -Alex [PATCH 1/6] rbd: fix leak of snapshots during initial probe [PATCH 2/6] rbd: make snap_size order parameter optional [PATCH 3/6] rbd: only update values on snap_info success [PATCH 4/6] rbd: rename __rbd_add_snap_dev() [PATCH 5/6] rbd: fix leak of format 2 snapshot names [PATCH 6/6] rbd: use rbd_obj_method_sync() return value -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html