On Wednesday, March 27, 2013 at 1:59 AM, Wido den Hollander wrote: > Hi, > > While working with rados_pool_list I stumbled upon what I think is a > documentation issue. > > librados.h tells me this: > > /** > * List objects in a pool > * > * Gets a list of pool names as NULL-terminated strings. The pool > * names will be placed in the supplied buffer one after another. > * After the last pool name, there will be two 0 bytes in a row. > * > * If len is too short to fit all the pool name entries we need, we > will fill > * as much as we can. > * > * @param cluster cluster handle > * @param buf output buffer > * @param len output buffer length > * @returns length of the buffer we would need to list all pools > */ > int rados_pool_list(rados_t cluster, char *buf, size_t len); > > "If len is too short to fit all the pool name entries we need, we will > fill as much as we can." > > From what I could remember it would return the length required if "len" > isn't long enough. Looking at the Python and PHP bindings (which I > wrote) it seems that is correct. > > It also says: "@returns length of the buffer we would need to list all > pools" > > Docs issue I guess? It certainly returns the amount of space needed; does it not also fill in the given buffer with however many pools it could? (It might not, but those sentences aren't contradictory in my mind.) -Greg Software Engineer #42 @ http://inktank.com | http://ceph.com -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
