On Fri, 22 Mar 2013, Gregory Farnum wrote: > I suspect users are going to easily get in trouble without a more > rigid separation between multi-linked and single-linked buckets. It's > probably best if anybody who's gone to the trouble of setting up a DAG > can't wipe it out without being very explicit ? so for instance "move" > should only work against a bucket with a single parent. Good idea; I'll add that. > Rather than > defaulting to all ancestors, removals should (for multiply-linked > buckets) require users to either specify a set of ancestors or to pass > in a "--all" flag. 'rm' only works on an empty bucket, so I'm not sure there is much danger is removing all links (and the bucket) in that case? > Also, I suspect that "rm" actually deletes the bucket while "unlink" > simply removes it from all parents (but leaves it in the tree); that > distinction might need to be a little stronger (or is possibly not > appropriate to leave in the CLI?). That's right. The "remove" versus "unlink" verbs make that pretty clear to me, at least... Are you suggesting this be clarified in the docs, or that the command set change? I think once we settle on the CLI, John can make a pass through the crush docs and make sure these commands are explained. > You mention that one of the commands "does nothing" under some > circumstances ? does that mean there's no error? If a command can't be > logically completed it should complain to the user, not just fail > silently. It returns -ENOTEMPTY; sorry, poor choice of words. :) sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
