On Wed, Mar 20, 2013 at 4:33 PM, Gregory Farnum <greg@xxxxxxxxxxx> wrote:
> This needs to handle versioning the encoding based on peer feature bits too.
>
> On Sun, Mar 17, 2013 at 7:51 AM, Yan, Zheng <zheng.z.yan@xxxxxxxxx> wrote:
>> + void add_dirfrag_base(CDir *dir) {
>> + ::encode(dir->dirfrag(), dirfrag_base);
>> + bufferlist bl;
>> + dir->_encode_base(bl);
>> + ::encode(bl, dirfrag_base);
>> + }
>
> We are guilty of doing this in other places, but we should avoid
> implicit encodings like this one, especially when the decode happens
> somewhere else like it does here. We can make a vector dirfrag_bases
> and add to that, and then encode and decode it along with the rest of
> the message — would that work for your purposes?
> -Greg
Sorry, a vector (called dirfrag_bases) of pair<dirfrag_t, bl> where bl
is the encoded base. Or something like that. :)
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
