On Thu, 14 Mar 2013, Greg Farnum wrote: > On Thursday, March 14, 2013 at 11:33 AM, Noah Watkins wrote: > > > > On Mar 14, 2013, at 11:29 AM, Greg Farnum <greg@xxxxxxxxxxx (mailto:greg@xxxxxxxxxxx)> wrote: > > > > > On Thursday, March 14, 2013 at 11:14 AM, Noah Watkins wrote: > > > > The current CephFS API is used to extract locality information as follows: > > > > > > > > First we get a list of OSD IDs: > > > > > > > > ceph_get_file_extent_osds(offset) -> [OSD ID]* > > > > > > > > Using the OSD IDs we can then query for the CRUSH bucket hierarchy: > > > > > > > > ceph_get_osd_crush_location(osd_id) -> path > > > > > > > > The path includes hostname information, but we'd still like to get the IP. The current API for doing this is: > > > > > > > > ceph_get_file_stripe_address(offset) -> [sockaddr]* > > > > > > > > that returns an IP for each OSD holds replicas. The order of the output list should be the same as the the OSD list, but It'd be nice to have a consistent API that deals with OSD id, making the correspondence explicit. > > > Agreed. We should probably deprecate the get_file_stripe_address() and make them turn IDs into addresses on their own. > > > > > > > > Is there an API deprecation protocol, or just -ENOTSUPP? > Well, for the moment I was thinking sticking "DEPRECATED" next to it and not using it anywhere else ? but that is probably an acceptable choice instead. I doubt anybody's using it outside of the old Hadoop bindings. Which I am looking forward to being able to purge out of all memory?. ;) Let's deprecate but leave in place for a while, until these bindings are completely done and out, and then EOPNOTSUPP the method a bit later. Unless those old bindings are already broken because of the preferred osd thing... s -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
