On Mon, Mar 4, 2013 at 11:25 AM, Alex Elder <elder@xxxxxxxxxxx> wrote: > On 03/04/2013 01:07 PM, Gregory Farnum wrote: >> On Mon, Mar 4, 2013 at 10:12 AM, Alex Elder <elder@xxxxxxxxxxx> wrote: >>> In ceph_con_in_msg_alloc(), if no alloc_msg method is defined for a >>> connection a new message is allocated with ceph_msg_new(). >>> >>> Drop the mutex before making this call, and make sure we're still >>> connected when we get it back again. >> >> Why do we need to drop the mutex at all? The mds_alloc_msg() that >> you're about to define doesn't seem to need it. >> -Greg >> > > My purpose in doing this is to make the third patch in > this series trivial to review. The one that doesn't set the page_alignment for mds messages? *confused* > That is, I make the code > here match what will happen when I unify how all alloc_msg > calls get made, as a pre-step, and then it's easier to see > that the later patch is correct. Oh, and we do do the mutex_lock and unlock pair around alloc_msg. Right, looks good! :) Reviewed-by: Greg Farnum <greg@xxxxxxxxxxx> > > I agree, it's not needed for that allocator. By the same > token, it almost certainly causes no harm, and the end result > will be consistent handling by all users of this interface. > > -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
