I'd just noticed utime on my laptop 32-bit build and was trying to figure out why our 32-bit nightly didn't see it. And Greg had seen the system build problem where I didn't, and I was isolating differences there as well. I purposely didn't spend time on the system() error handling because I was thinking of those calls as best-effort, if they fail the map will likely fail anyway, but there's no harm in handling errors, particularly if it'll shit the compiler up :) On Jan 27, 2013, at 12:57 PM, Danny Al-Gaaf <danny.al-gaaf@xxxxxxxxx> wrote: > Attached two patches to fix some compiler warnings. > > Danny Al-Gaaf (2): > utime: fix narrowing conversion compiler warning in sleep() > rbd: don't ignore return value of system() > > src/include/utime.h | 2 +- > src/rbd.cc | 36 ++++++++++++++++++++++++++++++------ > 2 files changed, 31 insertions(+), 7 deletions(-) > > -- > 1.8.1.1 > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
