Re: drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/22/2012 07:37 PM, Fengguang Wu wrote:
> Hi Alex,
> 
> FYI, there are new sparse warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus
> head:   c3e946ce7276faf0b302acd25c7b874edbeba661
> commit: c53d589337e9a211413484a604c76072e8474dc0 rbd: define rbd_dev_{create,destroy}() helpers
> date:   7 weeks ago

Quote a few of these have been addressed already in some upcoming
patches that didn't get reviewed in time for this cycle.  I appreciate
the notice though, and I'll fix this up soon.

Thanks a lot.

					-Alex

> drivers/block/rbd.c:1293:42: sparse: Using plain integer as NULL pointer
> drivers/block/rbd.c:1341:26: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1341:26:    expected unsigned long long [unsigned] [usertype] ver
> drivers/block/rbd.c:1341:26:    got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1351:46: sparse: Using plain integer as NULL pointer
> drivers/block/rbd.c:1395:26: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1395:26:    expected unsigned long long [unsigned] [usertype] ver
> drivers/block/rbd.c:1395:26:    got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1396:29: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1396:29:    expected unsigned long long [unsigned] [usertype] cookie
> drivers/block/rbd.c:1396:29:    got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1434:29: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1434:29:    expected unsigned long long [unsigned] [usertype] cookie
> drivers/block/rbd.c:1434:29:    got restricted __le64 [usertype] <noident>
> + drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static?
> drivers/block/rbd.c:2529:17: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:2529:17:    expected restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:2529:17:    got unsigned long long [unsigned] [long] [long long] <noident>
> drivers/block/rbd.c:2530:46: sparse: incorrect type in argument 2 (different base types)
> drivers/block/rbd.c:2530:46:    expected unsigned long long [unsigned] [usertype] snap_id
> drivers/block/rbd.c:2530:46:    got restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:2533:50: sparse: incorrect type in argument 2 (different base types)
> drivers/block/rbd.c:2533:50:    expected unsigned long long [unsigned] [usertype] snap_id
> drivers/block/rbd.c:2533:50:    got restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:1551:32: sparse: context imbalance in 'rbd_rq_fn' - unexpected unlock
> 
> Please consider folding the attached diff :-)
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Center
> Fengguang Wu, Yuanhan Liu                              Intel Corporation
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux