Re: [PATCH] rbd: Add --json flag for the showmapped command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/2012 12:57 AM, Stratos Psomadakis wrote:
On 12/13/2012 07:17 PM, Yehuda Sadeh wrote:
On Thu, Dec 13, 2012 at 7:37 AM, Stratos Psomadakis <psomas@xxxxxxxx> wrote:
Signed-off-by: Stratos Psomadakis <psomas@xxxxxxxx>
---
Hi Josh,

This patch adds the '--json' flag to enable dumping the showmapped output in
I think that it should be "--format=json" rather than --json. This
will make it more in line with other tools. Also, then you could have
the unpopular --format=xml.

Hi,

the problem is that --format is arleady used in rbd (to select the rbd
image format). So, you could either use --output-format= for
plain/json/xml output (but then you would be inconsistent wrt the other
tools), or change --format to --image-format (or something like that),
and use --format to select the output formatting.

We could deprecate --format in favor of --image-format, but maintain
backwards compatibility	by accepting the string 1 or 2 for --format
still. Maybe not pretty, but it lets us be consistent without changing
existing usage.

Josh
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux