Re: [PATCH] fix syncfs handling in error case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied, thanks!

sage

On Tue, 27 Nov 2012, Danny Al-Gaaf wrote:

> If the call to syncfs() fails, don't try to call syncfs again via
> syscall(). If HAVE_SYS_SYNCFS is defined, don't fall through to try
> syscall() with SYS_syncfs or __NR_syncfs.
> 
> Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@xxxxxxxxx>
> ---
>  src/common/sync_filesystem.h | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/src/common/sync_filesystem.h b/src/common/sync_filesystem.h
> index 5b23576..eff18d2 100644
> --- a/src/common/sync_filesystem.h
> +++ b/src/common/sync_filesystem.h
> @@ -34,14 +34,10 @@ inline int sync_filesystem(int fd)
>  #ifdef HAVE_SYS_SYNCFS
>    if (syncfs(fd) == 0)
>      return 0;
> -#endif
> -
> -#ifdef SYS_syncfs
> +#elif defined(SYS_syncfs)
>    if (syscall(SYS_syncfs, fd) == 0)
>      return 0;
> -#endif
> -
> -#ifdef __NR_syncfs
> +#elif defined(__NR_syncfs)
>    if (syscall(__NR_syncfs, fd) == 0)
>      return 0;
>  #endif
> -- 
> 1.8.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux