Re: libcephfs create file with layout and replication

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 18, 2012 at 12:05 PM, Noah Watkins <jayhawk@xxxxxxxxxxx> wrote:
> Wanna have a look at a first pass on this patch?
>
>    wip-client-open-layout
>
> Thanks,
> Noah

Just glanced over this, and I'm curious:
1) Why symlink another reference to your file_layout.h?
2) There's already a ceph_file_layout struct which is used "widely"
(MDS, kernel, userspace client). It also has an accompanying function
that does basic validity checks.


> On Sat, Nov 17, 2012 at 5:20 PM, Noah Watkins <jayhawk@xxxxxxxxxxx> wrote:
>> On Sat, Nov 17, 2012 at 4:15 PM, Sage Weil <sage@xxxxxxxxxxx> wrote:
>>>
>>> We ignore that for the purposes of getting the libcephfs API correct,
>>> though...
>>
>> Ok, make sense. Thanks.
>>
>> Noah

FYI, there's an "unused" __le32 in the open struct (used to be for
preferred PG). We should be able to steal that away without too much
pain or massaging! :)
-Greg
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux