On 10/25/2012 04:28 PM, Dan Mick wrote: > >>> static void ceph_fault(struct ceph_connection *con) >>> __releases(con->mutex) >>> { >>> pr_err("%s%lld %s %s\n", ENTITY_NAME(con->peer_name), >>> ceph_pr_addr(&con->peer_addr.in_addr), con->error_msg) >>> >>> Perhaps this should become pr_info() or something. Sage? >> >> Yeah, I think pr_info() is probably the right choice. Do you know if >> that >> hits the console by default, or just dmesg/kern.log? > > pr_info is level 6, KERN_INFO; by default, /proc/sys/kernel/printk has > 4 4 1 7 in it, the first 4 of which means 4-and-lower go to console. So > debug, info, notice messages all are options for "not console". > Excellent. So pr_info() it is. Dan you want to implement this? -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html