re: ceph: fix encoding of ino only (not relative) paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sage Weil,

This is a semi-automatic email about new static checker warnings.

The patch 795858dbd253: "ceph: fix encoding of ino only (not 
relative) paths" from Aug 15, 2011, leads to the following Smatch 
complaint:

fs/ceph/mds_client.c:1593 set_request_path_attr()
	 error: we previously assumed 'rpath' could be null (see line 1590)

fs/ceph/mds_client.c
  1589			     *ppath);
  1590		} else if (rpath || rino) {
                           ^^^^^^^^^^^^^
Check.

  1591			*ino = rino;
  1592			*ppath = rpath;
  1593			*pathlen = strlen(rpath);
                                   ^^^^^^^^^^^^^
Dereference.

  1594			dout(" path %.*s\n", *pathlen, rpath);
  1595		}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux