This second series consists of fairly simple bits of code cleanup. It is available as branch "wip-rbd-review-2" on the ceph-client git repository, and is based on the branch "wip-rbd-review-1". https://github.com/ceph/ceph-client/tree/wip-rbd-review-2 -Alex [PATCH 1/5] a0f6877 rbd: define rbd_assert() This defines a new macro rbd_assert() that's used to express invariant properties assumed by the code. If the property does not hold it triggers a BUG(). Everywhere that BUG_ON() had been used is replaced with an equivalent call to rbd_assert(). [PATCH 2/5] a8aac82 rbd: rename rbd_id_get() [PATCH 3/5] 12c5aa2 rbd: rename __rbd_init_snaps_header() These rename some symbols to align better with how their used. [PATCH 4/5] e8cb272 rbd: kill rbd_dev->q [PATCH 5/5] 1557afc rbd: kill rbd_image_header->total_snaps These eliminate two struct fields, one which is unused and the other which is redundant and therefore not necessary. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html