Re: [PATCH v2] libceph: Fix sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/23/2012 03:14 PM, Iulius Curt wrote:
From: Iulius Curt<iulius.curt@xxxxxxxxx>

Make ceph_monc_do_poolop() static to remove the following sparse warning:
  * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
    declared. Should it be static?
Also drops the 'ceph_monc_' prefix, now being a private function.

Signed-off-by: Iulius Curt<icurt@xxxxxxxxxxx>
---
v1 --->  v2
  * drop the 'ceph_monc_' prefix
---
  net/ceph/mon_client.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
index 105d533..84ce495 100644
--- a/net/ceph/mon_client.c
+++ b/net/ceph/mon_client.c
@@ -613,7 +613,7 @@ bad:
  /*
   * Do a synchronous pool op.
   */
-int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
+static int do_poolop(struct ceph_mon_client *monc, u32 op,
  			u32 pool, u64 snapid,
  			char *buf, int len)
  {
@@ -663,7 +663,7 @@ out:
  int ceph_monc_create_snapid(struct ceph_mon_client *monc,
  			    u32 pool, u64 *snapid)
  {
-	return ceph_monc_do_poolop(monc,  POOL_OP_CREATE_UNMANAGED_SNAP,
+	return do_poolop(monc,  POOL_OP_CREATE_UNMANAGED_SNAP,
  				   pool, 0, (char *)snapid, sizeof(*snapid));

  }
@@ -672,7 +672,7 @@ EXPORT_SYMBOL(ceph_monc_create_snapid);
  int ceph_monc_delete_snapid(struct ceph_mon_client *monc,
  			    u32 pool, u64 snapid)
  {
-	return ceph_monc_do_poolop(monc,  POOL_OP_CREATE_UNMANAGED_SNAP,
+	return do_poolop(monc,  POOL_OP_CREATE_UNMANAGED_SNAP,
  				   pool, snapid, 0, 0);

  }
--
1.7.9.5


Hi Sage,

Can you, please, have a look.

Thanks,
Iulius

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux