On Mon, Jul 30, 2012 at 4:14 PM, Sage Weil <sage@xxxxxxxxxxx> wrote: > > On Tue, 24 Jul 2012, Yehuda Sadeh wrote: > > On Fri, Jul 20, 2012 at 5:41 PM, Sage Weil <sage@xxxxxxxxxxx> wrote: > > > From: caleb miles <caleb.miles@xxxxxxxxxxx> > > > > > > The server side recently added support for tuning some magic > > > crush variables. Decode these variables if they are present, or use > > > the > > > default values if they are not present. > > > > > > Corresponds to ceph.git commit > > > 89af369c25f274fe62ef730e5e8aad0c54f1e5a5. > > > > > > Signed-off-by: caleb miles <caleb.miles@xxxxxxxxxxx> > > > Reviewed-by: Sage Weil <sage@xxxxxxxxxxx> > > > --- > > > include/linux/ceph/ceph_features.h | 4 ++- > > > include/linux/crush/crush.h | 8 +++++++ > > > net/ceph/crush/mapper.c | 13 ++++++----- > > > net/ceph/osdmap.c | 39 > > > ++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 57 insertions(+), 7 deletions(-) > > > > > > diff --git a/include/linux/ceph/ceph_features.h > > > b/include/linux/ceph/ceph_features.h > > > index 342f93d..df25dcf 100644 > > > --- a/include/linux/ceph/ceph_features.h > > > +++ b/include/linux/ceph/ceph_features.h > > > @@ -12,12 +12,14 @@ > > > #define CEPH_FEATURE_MONNAMES (1<<5) > > > #define CEPH_FEATURE_RECONNECT_SEQ (1<<6) > > > #define CEPH_FEATURE_DIRLAYOUTHASH (1<<7) > > > +#define CEPH_FEATURE_CRUSH_TUNABLES (1<<18) > > > > any reason why this is 18 and not 8? > > 9-17 are used.. just not implemented/used by the kernel code. > Maybe mention it somewhere in a comment, to avoid future confusion? -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
