On 07/19/2012 10:09 AM, Alex Elder wrote:
This series of patches changes the way the snap context "seq" field
is used. Currently it is used in a way that isn't really useful, and
as such is a bit confusing. This behavior seems to be a hold over
from a time when there was no snap_id field maintained for an rbd_dev.
Summary:
[PATCH 1/4] rbd: don't use snapc->seq that way
Removes special handling in __rbd_refresh_header() that ensured
the seq field was updated to point to the head if it had been
at the start of the function.
[PATCH 2/4] rbd: preserve snapc->seq in rbd_header_set_snap()
Changes rbd_header_set_snap() so it doesn't set the seq field
to the snapshot id (for a snapshot mapping) or the highest
snapshot id (for the base image).
[PATCH 3/4] rbd: set snapc->seq only when refreshing header
Assigns snapc->seq whenever an updated rbd image header is
received rather than when a new snapshot id has been
assigned.
[PATCH 4/4] rbd: kill rbd_image_header->snap_seq
Gets rid of the rbd_image_header->snap_seq field, which
previously kept the same information now maintained in
the snapc->seq field.
-Alex
The rest of the series looks good too.
Reviewed-by: Josh Durgin <josh.durgin@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
