Re: [PATCH] libceph: trivial fix for the incorrect debug output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-07-16 at 07:55 -0500, Alex Elder wrote:
> On 07/15/2012 01:45 AM, Jiaju Zhang wrote:
> > This is a trivial fix for the debug output, as it is inconsistent
> > with the function name so may confuse people when debugging.
> > 
> > Signed-off-by: Jiaju Zhang <jjzhang@xxxxxxx>
> 
> I have been converting these to use __func__ whenever I touch
> code nearby.  Mind if I do that here as well?
> 
> Reviewed-by: Alex Elder <elder@xxxxxxxxxxx>

Oh, please do;) Using __func__ would be good.
Thanks for the review.

Thanks,
Jiaju

> 
> > ---
> >  net/ceph/osd_client.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> > index 1ffebed..ad6d745 100644
> > --- a/net/ceph/osd_client.c
> > +++ b/net/ceph/osd_client.c
> > @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd)
> >  
> >  static void remove_all_osds(struct ceph_osd_client *osdc)
> >  {
> > -	dout("__remove_old_osds %p\n", osdc);
> > +	dout("__remove_all_osds %p\n", osdc);
> 
>         dout("%s %p\n", __func__, osdc);
> 
> >  	mutex_lock(&osdc->request_mutex);
> >  	while (!RB_EMPTY_ROOT(&osdc->osds)) {
> >  		struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux