On 07/13/2012 06:06 AM, Vladimir Bashkirtsev wrote:
On 13/07/12 01:30, Tommi Virtanen wrote:
On Wed, Jul 11, 2012 at 9:41 PM, Josh Durgin <josh.durgin@xxxxxxxxxxx>
wrote:
You're right about the object name - you can get its offset in the
image that way. Since rbd is thin-provisioned, however, the highest
index object might not be the highest possible object. When you first
create an image, only the header object is created.
You can re-create it with a size that's known to be greater than the
old size (put in a terabyte extra, or something), and then use a
partitioning tool to see what the disk layout really is, and resize
based on that.
Good point. However ceph should not be aware of image internal
structure. In most installations image would contain partition table
which obviously may be used to calculate image size but in some cases
(when whole image is used for something) it may not be. Perhaps good
point for RBD would be to create first and last object for image when
RBD header is created. Will waste a bit of space but generally these
objects will hold partitioning information and just their existence
would allow to establish boundaries of the image. Does not help with
snapshots though. But definitely will be helpful for a recovery tool.
Ceph definitely needs to store the image size. Things like qemu need
to know the size of the block device to report to the guest bios. It's
also useful to know how much space your rbd images have allocated. We
can't assume there's a partition table, or that it's accurate. Ceph
shouldn't need to interpret the contents of an image, since it's
defined by the end user.
Since rbd images can have sizes that are not multiples of their object
size, it also wouldn't give you the exact size. Also, using discard/TRIM
support, objects may be deleted.
If you always make your images a multiple of object size, you never use
discard/TRIM, and you write to the end of the image after you create
it, you could tell the size from highest numbered object that exists.
I don't think this buys you much over doing what Tommi suggested.
Josh
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
