On Fri, 13 Jul 2012 09:36:57 -0500 Alex Elder <elder@xxxxxxxxxxx> wrote: > On 07/13/2012 09:28 AM, Alan Cox wrote: > > From: Alan Cox <alan@xxxxxxxxxxxxxxx> > > > > We re-run the loop but we don't re-set the attrs pointer back to NULL. > > It looks to me like we're OK here without this. > > At the top of the loop, the if condition either holds or it does not. > - If it does not, we don't touch "xattrs" again, before returning "err". > - If the condition holds, the next time "xattrs" is touched is when its > value is assigned the result of a kcalloc() call. If the condition is invariant across the race/retry then a better fix would be to move the start label to re-execute only the relevant code ? Alan -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
