On Tue, Jun 19, 2012 at 08:27:19AM -0500, Alex Elder wrote: > On 06/19/2012 05:33 AM, Dan Carpenter wrote: > > We dereference "con->in_msg" on the line after it was set to NULL. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Yikes. > > Actually I think I prefer a different fix, which is > simply to call ceph_con_put(con) in the same spot > it was called with con->in_msg->con before. I'd > rather drop the message reference before dropping > the connection reference. I.e.: > > @@ -440,7 +440,7 @@ static void reset_connection(struct ceph_connection > *con) > con->in_msg->con = NULL; > ceph_msg_put(con->in_msg); > con->in_msg = NULL; > - ceph_con_put(con->in_msg->con); > + ceph_con_put(con); > } > > con->connect_seq = 0; > > (I crafted that manually--it may not work...) > > I will re-post that fix and will credit you with it. Please acknowledge > it's OK with you though. Thanks a lot. > Yep. We already know that con->in_msg->con and con are the same from the BUG_ON() so this works. Thanks. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
