On Fri, 1 Jun 2012, Alex Elder wrote: > On 05/31/2012 11:24 PM, Sage Weil wrote: > > Also: when poking around, I noticed that ceph_con_get() and put() are > > called directly from osd_client.c... that's a bug! Those connections have > > a get and put op defined that twiddles the containing ceph_osd struct's > > ref count. > > So are you saying that the calls in "osd_client.c" to ceph_con_get() > and ceph_con_put() should instead be calls to get_osd_con() and > put_osd_con(), respectively? (Or more generally con->ops->get() > and con->ops->put()?) Yeah.. one of the patches I pushed [er, and pushing now] fixes that. sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html