Reviewed-by: Yehuda Sadeh <yehuda@xxxxxxxxxxx>
On Wed, May 30, 2012 at 12:34 PM, Alex Elder <elder@xxxxxxxxxxx> wrote:
> The ceph connection state "DEAD" is never set and is therefore not
> needed. Eliminate it.
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
> ---
> include/linux/ceph/messenger.h | 1 -
> net/ceph/messenger.c | 6 ------
> 2 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/ceph/messenger.h b/include/linux/ceph/messenger.h
> index 2521a95..aa506ca 100644
> --- a/include/linux/ceph/messenger.h
> +++ b/include/linux/ceph/messenger.h
> @@ -119,7 +119,6 @@ struct ceph_msg_pos {
> #define CLOSED 10 /* we've closed the connection */
> #define SOCK_CLOSED 11 /* socket state changed to closed */
> #define OPENING 13 /* open connection w/ (possibly new) peer */
> -#define DEAD 14 /* dead, about to kfree */
> #define BACKOFF 15
>
> /*
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 1a80907..42ca8aa 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -2087,12 +2087,6 @@ bad_tag:
> */
> static void queue_con(struct ceph_connection *con)
> {
> - if (test_bit(DEAD, &con->state)) {
> - dout("queue_con %p ignoring: DEAD\n",
> - con);
> - return;
> - }
> -
> if (!con->ops->get(con)) {
> dout("queue_con %p ref count 0\n", con);
> return;
> --
> 1.7.5.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
