I got lots of NULL pointer dereference Oops when compiling kernel on ceph. The bug is because the kernel page migration routine replaces some pages in the page cache with new pages, these new pages' private can be non-zero. Signed-off-by: Zheng Yan <zheng.z.yan@xxxxxxxxx> --- fs/ceph/addr.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 173b1d2..1f180b1 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -984,7 +984,10 @@ retry_locked: BUG_ON(!ci->i_snap_realm); down_read(&mdsc->snap_rwsem); BUG_ON(!ci->i_snap_realm->cached_context); - snapc = (void *)page->private; + if (PagePrivate(page)) + snapc = (void *)page->private; + else + snapc = NULL; if (snapc && snapc != ci->i_head_snapc) { /* * this page is already dirty in another (older) snap -- 1.7.6.5 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html