On Wednesday, March 14, 2012 at 11:21 PM, Noah Watkins wrote: > This is version 2 of the generic libcephfs Java bindings based on feedback from the original patch set (thanks!). The short-log at the bottom of the e-mail shows the commits made based on feedback, but the Git branch below has them all rebased into fewer patches for a clean history. > > Thanks, > - Noah > > Consolidated patch set is available in the git repository at: > > git://github.com/noahdesu/ceph (http://github.com/noahdesu/ceph) wip/java-cephfs > > Noah Watkins (3): > java: add Java and C++ source files > automake: setup autotools to build cephfs-java > debian: add libcephfs-java package > > Sage Weil (2): > do_autogen.sh (http://do_autogen.sh): add -j flag to enable java stuff > Makefile: add src/include to #include path for libcephfs_jni_la > > ============================================================ > Original change log based on feedback > ============================================================ > > Noah Watkins (12): > java: add Java and C++ source files > java: setup autotools to build cephfs-java > debian: add libcephfs-java package > java: add MIT license > java: document valid states in JavaDoc > java: order methods according to libcephfs.h > java: fix typo; update testing notes > java: remove redundant mount() interface > java: use protected getdnames(int bufSize) But you left it public in CephMount? > java: switch classpath to com.ceph.fs > java: remove unused macro > java: document CPP macro-foo Looks like a couple of my line notes are still left. Am I just confused in my opinions? :( There's no note that set_default_file_replication is a no-op in its documentation. closedir does not explain what happens to the CephDirectory state under success and failure. Honestly I don't even know what you're supposed to do with it if it fails, and why the code resets it to PREPARING instead of a CLOSED state is unclear to me. :) If possible for my reviewing sanity, it'd be nice if I could access the changes you've made to things instead of trying to figure out how to run diffs against changing filenames and stuff, too, but that's just a wish. Thanks for your work! -Greg -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
