Re: [PATCH 1/3] java: add Java and C++ source files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 2, 2012 at 16:48, Noah Watkins <jayhawk@xxxxxxxxxxx> wrote:
> This adds all of the Java and C++ source files that make up the
> libcephfs Java wrappers package.
...
> +2. Set CEPHFS_CONF environment variable to point to a ceph.conf. This can be
> +ommitted if the desired configuration file can be found in a default location.

Simple typo, "omitted".

> +package net.newdream.ceph.fs;

I think com.ceph.fs would be a smaller punishment on the programmers
using this, and we have that domain name.

> diff --git a/src/java/test/CephMountCreateTest.java b/src/java/test/CephMountCreateTest.java
...
> + * This tests the mount root dir functionality. It creates an empty
> + * directory in the real root, then it re-mounts the file system
> + * with the empty directory specified as the root. Assertions are
> + * that the "/" in the normal mount is non-empty, and that "/" is
> + * empty in the mount with the empty directory as the root.

So the JUnit tests require a functional ceph cluster to run. Can you
state that explicitly in the source/docs, please?



I did not dig deep, and I'm no Java expert, but more client-side
support is exciting stuff!
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux