On 03/02/2012 01:31 PM, Sage Weil wrote:
> +/*
> + * The basic unit of block I/O is a sector. It is interpreted in a
> + * number of contexts in Linux (blk, bio, genhd), but the default is
> + * universally 512 bytes. These symbols are just slightly more
> + * meaningful than the bare numbers they represent.
> + */
> +#define SECTOR_SHIFT 9
> +#define SECTOR_SIZE (1ULL<< SECTOR_SHIFT)
> +
I would expect the block layer already has #defines for these?
I would too, but I don't see it. I think "9" and "512" are
considered obvious enough.
I still prefer this though; if nothing else it makes it easy
to search for places we are using things with this meaning.
-Alex
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
