These all look good. Reviewed-by: Sage Weil <sage@xxxxxxxxxxxx> On Tue, 28 Feb 2012, Alex Elder wrote: > This series affects the way arguments are parsed in rbd_add(). > It first encapsulates the code into its own helper function. > Then it uses a few simple tokenization functions instead of > sscanf() to parse the string provided, which makes it possible > to do a better job of error checking the input. It makes use > of the ability to check for certain invariants at build time > rather than runtime. And by reworking what information gets > passed around, eliminates the need to allocate a buffer to > hold the monitor addresses. > > -Alex > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html